Change progress status to Completed in modules #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_module function.
donnapep
approved these changes
Feb 25, 2019
alexsanford
pushed a commit
that referenced
this pull request
Mar 25, 2019
…er_module function. (#2342)
donnapep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As stated in issue #2313 the status doesn't change from "In Progress" to "Completed" even if all modules are marked completed.
Problem description
The template-function.php file calls the get_user_module_progress() function from the class-sensei-modules.php. The resulting progress number is determining the output for the progress tab on the page. The problem is that when the get_user_module_progress() runs it doesn't get the correct input.
Solution
To solve this I have added one line of code, calling a function to make sure that the progress data is up to date and saved to the metadata, so the input is correct before it's processed and sent back to determine the status of the module.
Test
To test load a page with all completed lessons and also add new lessons and mark them as completed to check correct functionaity.